Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release_notes.tpl.txt #19122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update release_notes.tpl.txt #19122

wants to merge 1 commit into from
+6 −6

Conversation

sunfeilong
Copy link

Add space between ${ETCD_VER} and Path

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@sunfeilong
Update release_notes.tpl.txt
c667fa3 
Add space between ${ETCD_VER} and Path
@k8s-ci-robot
Copy link

Hi @sunfeilong. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jan 8, 2025

Hi @sunfeilong, thanks for your pull request. Hi. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:

git commit --amend --signoff # Fix the signed off trailer
git push --force

@ivanvc ivanvc mentioned this pull request Jan 8, 2025
Open
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, sunfeilong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
approved needs-ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunfeilong @k8s-ci-robot @ivanvc @serathius